-
Notifications
You must be signed in to change notification settings - Fork 35
Swipe gesture icon position #121
base: master
Are you sure you want to change the base?
Conversation
What is the error that you are getting? |
Test version of Dank has been automatically built from this pull request. |
Well.. I can't run that apk either. It crashes upon launch. Logcat yields this saket#18 I've tried invalidating caché, deleting folders, even checking out the project again. My 'multiple accounts' branch which is several commits behind master, builds and runs ok. But on master I get the same result as the bot just built |
Can you check whether changing dependency like done here: slapperwan/gh4a@e34181f would fix the issue? |
@Tunous I'll try it that. Can you install and run this APK? |
The one from this build also doesn't build for me. I'm pretty sure that's the issue with this library but didn't test how it works with the alternative. |
Ok. I'll check that because master branch is broken at least for me. Thanks. |
Yes, that works. I've tested on this branch and works just fine. |
- Cannot click links in thread view
Another dep seems to be broken. Downloading images crash the app. It's not related to this branch, I built from master sources. |
Test version of Dank has been automatically built from this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that this would work nicely if the icon always stayed in the middle of the visible part of the comment instead of being positioned under the touch point.
@Tunous Sorry, I currently don't have any free time left to work on this PR. |
@Esselans No worries, as long as these changes are still here someone else can take them and continue on your work. I'll add help wanted label then to indicate that. |
@Tunous I can't build Dank anymore since the last commits. I've tried everything by now. So I can't check if this stills works.. I've recover this branch using git reflog. It does build but it does not run on my phone.
Closes #18