Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Border Parser #3

Merged
merged 5 commits into from
Feb 4, 2024
Merged

Conversation

K-Kumar-01
Copy link
Collaborator

No description provided.

K-Kumar-01 and others added 4 commits January 31, 2024 19:12
add support for border attribute table tag
handle the border style property for table cells
update the borderStrike and borderColor assignment

Signed-off-by: Kushal Kumar <kushalkumargupta4@gmail.com>
Signed-off-by: Kushal Kumar <kushalkumargupta4@gmail.com>
Signed-off-by: K-Kumar-01 <59891164+K-Kumar-01@users.noreply.github.com>
Signed-off-by: K-Kumar-01 <59891164+K-Kumar-01@users.noreply.github.com>
@nicolasiscoding nicolasiscoding added the enhancement New feature or request label Feb 1, 2024
Copy link
Member

@nicolasiscoding nicolasiscoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Don't repeat yourself" 😄

src/helpers/xml-builder.js Show resolved Hide resolved
src/helpers/xml-builder.js Show resolved Hide resolved
src/helpers/xml-builder.js Show resolved Hide resolved
src/helpers/xml-builder.js Outdated Show resolved Hide resolved
src/helpers/xml-builder.js Outdated Show resolved Hide resolved
src/helpers/xml-builder.js Show resolved Hide resolved
src/helpers/xml-builder.js Outdated Show resolved Hide resolved
…figuration

Signed-off-by: K-Kumar-01 <59891164+K-Kumar-01@users.noreply.github.com>
@nicolasiscoding nicolasiscoding merged commit 69a0119 into develop Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants