Skip to content

Commit

Permalink
Build: Show TVNC_GLX value as 0/1
Browse files Browse the repository at this point in the history
This is purely cosmetic.  For CMake boolean variables that are used in
packaging scripts, we call boolean_number(<variable> PARENT_SCOPE) to
set the variable's value to 0 or 1 in the parent scope, which is what
the packaging scripts expect.  However, we also need to call
boolean_number(<variable>) to set the variable's value to 0 or 1 in the
current scope.  This makes the output of report_option() consistent for
all boolean variables, regardless of whether they were specified as 1/0,
TRUE/FALSE, ON/OFF, YES/NO, or Y/N.  It also directs users toward the
most intuitive and linguistically-neutral way to set or change a boolean
variable's value.
  • Loading branch information
dcommander committed Aug 23, 2023
1 parent cc4ff8a commit 23de48e
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions unix/Xvnc/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,7 @@ if(NOT APPLE)
option(TVNC_GLX
"Include GLX extension in Xvnc (causes Xvnc to depend on the system's libX11 and libXext)"
ON)
boolean_number(TVNC_GLX)
report_option(TVNC_GLX "GLX extension")
endif()

Expand Down

0 comments on commit 23de48e

Please sign in to comment.