Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New extension: Wheel Scroll #1122

Open
wants to merge 37 commits into
base: master
Choose a base branch
from
Open

Conversation

DDen4ik-12
Copy link

@DDen4ik-12 DDen4ik-12 commented Nov 1, 2023

WheelScroll
I created the "Wheel Scroll" extension. It has two event blocks that are runs scripts when the mouse wheel is scrolled.

Blocks

When mouse wheel scrolls whenScroll

whenScroll
This event block runs scripts when the mouse wheel is scrolls in any direction.

When mouse wheel scrolls [SCROLL_TYPE] whenScrollDir

whenScrollDir
This event block runs scripts when the mouse wheel scrolls in the specified direction.
This block has a SCROLL_TYPE list with direction types:

  • up
  • down
  • to the left
  • to the right
  • out
  • in
  • along the x-axis
  • along the y-axis
  • along the z-axis

@CST1229
Copy link
Collaborator

CST1229 commented Nov 1, 2023

This could probably be put in Sensing+.

@CubesterYT
Copy link
Member

Is wheel intentionally mispelled everywhere?

@DDen4ik-12 DDen4ik-12 changed the title Add "Whell Scroll" extension Add "Wheel Scroll" extension Nov 1, 2023
@DDen4ik-12
Copy link
Author

Is wheel intentionally mispelled everywhere?

In this word, I'm confusing the letter that needs to be written twice.

@GarboMuffin GarboMuffin changed the title Add "Wheel Scroll" extension New extension: Wheel Scroll May 10, 2024
@DDen4ik-12 DDen4ik-12 closed this Jun 25, 2024
@DDen4ik-12 DDen4ik-12 reopened this Jul 14, 2024
@DDen4ik-12
Copy link
Author

DDen4ik-12 commented Jul 14, 2024

Update 1.1 + Small update

New blocks

delta [DELTA_TYPE] getDelta

Новый блок
This reporter gets scrolling delta in the specified axis, or gets delta mode.
Use this block in scripts starting with one of these event blocks:
Событийные блоки

@CubesterYT
Copy link
Member

If you're done with your extension, later in the day, I will add translation functions and fix some things.

@DDen4ik-12
Copy link
Author

If you're done with your extension, later in the day, I will add translation functions and fix some things.

I have finished making the extension

@CubesterYT
Copy link
Member

Got it, I'll add it to my to do list

Copy link
Member

@CubesterYT CubesterYT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great extension! I can't believe it's been in PR's for a while. Now we just wait on GarboMuffin to check it out.

@GarboMuffin
Copy link
Member

okay, i like the icon, i like the event block, but the block to get how much you scrolled by only working inside of the event block feels wrong, it doesn't match how the existing mouse x/y works

@GarboMuffin
Copy link
Member

GarboMuffin commented Jul 26, 2024

there was another pull request that made them work outside of the event block by just summing up delta x/y/z, but that feels wrong because these are not absolute positions but just relative values, and also incompatible with exposing deltaMode

the precedent from pointerlock -- good or bad -- is for the blocks to return the delta from the previous frame

which has some interesting questions, like what happens if someone scrolls both up and down in the time between two frames

@DDen4ik-12
Copy link
Author

okay, i like the icon, i like the event block, but the block to get how much you scrolled by only working inside of the event block feels wrong, it doesn't match how the existing mouse x/y works

I've made this block work outside of event blocks

@GarboMuffin GarboMuffin added the pr: new extension Pull requests that add a new extension label Oct 14, 2024
@yuri-kiss
Copy link
Member

yuri-kiss commented Dec 24, 2024

Similar PR: #638

This could probably be merged into cursor.
As well as this could merge with lily's changes or one of the 2 can supersede some parts or the whole of the other PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: new extension Pull requests that add a new extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants