-
-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The plan with custom extensions #633
Comments
Awesome. Glad to see unsandboxed extensions getting full support! Plan to add any community ones to the extension list? |
The plan is to restrict unsandboxed extensions to extensions.turbowarp.org (no change for current sandboxed extensions), but allow community contributions to that website as long as they follow guidelines like "don't break compatibility with old extension versions" and "don't introduce security bugs" |
https://twitter.com/GarboMuffin/status/1584025942376448001 The hope is that users will be able to start using this in ~1wk |
See: #633 Custom extensions from extensions.turbowarp.org will be loaded automatically and without sandbox. For other extensions, a prompt has been added to ask the user for permission to load the extension.
Prototypes can be tested now: Extension URLs will be stored in the project. Extensions from https://extensions.turbowarp.org/ will be loaded automatically and unsandboxed. For extensions from other places, a prompt will be displayed and they will be loaded with the sandbox. The prompt is rather ugly and needs some more work. It's not clear what the final solution will be for locally testing unsandboxed extensions. For now, I've made it so extensions with a URL beginning with extensions.turbowarp.org can probably start accepting contributions over here: https://github.com/TurboWarp/extensions. The acceptance criteria is basically something like "nothing malicious, no security bugs, don't break compatibility". |
Also, there is some draft documentation here: https://docs.turbowarp.org/development/unsandboxed-extensions |
I might be able to work on the https://extensions.turbowarp.org site CSS/layouts or make some improvements in order to increase consistency with other Turbowarp tools. 👍 Also, could the item "Advertise extensions.turbowarp.org in the editor" be solved by adding an option under the Edit > menu in the Turbowarp editor called "Unsandboxed Extensions" that opens the https://extensions.turbowarp.org site? |
Feel free to take a shot at redesigning extensions.turbowarp.org. You can't do worse than the current design. As for advertising these in the editor, I was intending to add an item alongside the custom extension button that says something about visiting that website to find some more extensions. Something like that. |
See: #633 Custom extensions from extensions.turbowarp.org will be loaded automatically and without the sandbox. For other extensions, a prompt has been added to ask the user for permission to load the extension.
Unsandboxed extensions are now usable on the normal turbowarp.org without any experiment branches |
Checkboxes mean "the code has been written", not necessarily "you can use it now"
isEdgeActivated: false
The text was updated successfully, but these errors were encountered: