Updating jsts dependency for react-native compatibility #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
3 similar comments
|
+1 |
|
+1 |
|
+1 |
|
+1 Would love to see this occur. |
|
(bump) +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The current version of jsts that this package uses exports a global (
jsts) unexplicitly (i.e., notwindow.jsts)This breaks the package in (react native's) strict mode.
I updated the dependency and used the GeoJSONWriter (the GeoJSONParser is gone in the latest version of jsts).
When shrinkwrapping I got weird results (probably because I am using npm@3?) It adds all dependencies (including devDependencies) to the shrinkwrap, and marks jsts as @latest, I guess the idea is that it locks it at a specific version, so I guess we will have to update the
npm-shrinkwrap.jsonmanually.Thanks for turf, I enjoy using it a lot