-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial commit SSR pages #127
Conversation
@rowanwins 👍 Sweet looks good, the search box is way nicer now that it filters out the categories (no need for descriptions being searchable).
I'd say it's ready to be merged as the new docs 👍 🎉 Great job @rowanwins |
"start": "webpack-dev-server --open --hot", | ||
"lint": "eslint --ext .js,.vue src" | ||
"create-config": "node scripts/create-config.js", | ||
"start": "nuxt", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rowanwins I dropped start & build
in favor of using the "hot reloading" nuxt
command.
From what I gather the nuxt generate
command builds the bundle for the web, so no need to run nuxt build
& nuxt start
The links are back up, I forgot to update the config file |
@@ -1,34 +1,36 @@ | |||
<template> | |||
<div id='turfMap' style="height: 400px"></div> | |||
<div id='turfMap' style="height: 325px"></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rowanwins Made the map smaller to better fit the @example
at the very bottom.
<strong>Note:</strong> {{module.name}} is part of the {{module.npmName}} module.<br><br> | ||
To use it as a stand-alone module will need to import {{module.npmName}} and call the {{module.name}} method. | ||
</p> | ||
</div> | ||
</Col> | ||
<Col span="24"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rowanwins @example
is now on it's own 24 span Column, noticed a lot of examples were getting "clipped" on smaller resolution browser windows.
This isn't a mobile-friendly solution, but it's a tad better on my tiny screen 😄
@rowanwins 👍 Looks great so far, going to merge this and 🤞 hope nothing breaks. |
Gday @DenisCarriere & @stebogit
Attached is a new version of the docs.
A few more improvements to come
Anyway thought I'd drop this in for anyone to take a look