Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit SSR pages #127

Merged
merged 11 commits into from
Dec 5, 2017
Merged

Initial commit SSR pages #127

merged 11 commits into from
Dec 5, 2017

Conversation

rowanwins
Copy link
Member

Gday @DenisCarriere & @stebogit

Attached is a new version of the docs.

  • This uses nuxt to generate the pages as static html which should be better for search engines
  • The docs are now all on a single page
  • Built sizes are much better than the current
  • The map moves to a module when it's description comes into view, I think this functions reasonably nicely.

A few more improvements to come

  • Still need to improve the built size, the component library Im using isn't playing nicely with nuxt for import on demand just at the moment so I just need another few hours playing with it
  • I could also tweak the search box to also inc search module descriptions, although with the docs now all on a single page this is less necessary.

Anyway thought I'd drop this in for anyone to take a look

@DenisCarriere
Copy link
Member

DenisCarriere commented Dec 5, 2017

@rowanwins 👍 Sweet looks good, the search box is way nicer now that it filters out the categories (no need for descriptions being searchable).

  • Noticed the links (LineString, Feature, etc...) weren't being generated anymore?.. I'm sure it's an easy fix, I'll look into it.

I'd say it's ready to be merged as the new docs 👍 🎉 Great job @rowanwins

@DenisCarriere
Copy link
Member

DenisCarriere commented Dec 5, 2017

🤔 Don't know what happened here...

kapture 2017-12-05 at 7 42 56

✅ Fixed

kapture 2017-12-05 at 8 04 36

"start": "webpack-dev-server --open --hot",
"lint": "eslint --ext .js,.vue src"
"create-config": "node scripts/create-config.js",
"start": "nuxt",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rowanwins I dropped start & build in favor of using the "hot reloading" nuxt command.

From what I gather the nuxt generate command builds the bundle for the web, so no need to run nuxt build & nuxt start

@DenisCarriere
Copy link
Member

The links are back up, I forgot to update the config file yarn create-config (I've now added in the pregenerate script)

@@ -1,34 +1,36 @@
<template>
<div id='turfMap' style="height: 400px"></div>
<div id='turfMap' style="height: 325px"></div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rowanwins Made the map smaller to better fit the @example at the very bottom.

<strong>Note:</strong> {{module.name}} is part of the {{module.npmName}} module.<br><br>
To use it as a stand-alone module will need to import {{module.npmName}} and call the {{module.name}} method.
</p>
</div>
</Col>
<Col span="24">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rowanwins @example is now on it's own 24 span Column, noticed a lot of examples were getting "clipped" on smaller resolution browser windows.

This isn't a mobile-friendly solution, but it's a tad better on my tiny screen 😄

@DenisCarriere
Copy link
Member

@rowanwins 👍 Looks great so far, going to merge this and 🤞 hope nothing breaks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants