-
Notifications
You must be signed in to change notification settings - Fork 951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test @example in TurfJS core #859
Comments
👍 👍 @DenisCarriere |
@DenisCarriere should I just add "test": "npm run lint && lerna bootstrap && tap packages/*/test.js && npm run types && npm run lintAPI",
"lintAPI": "documentation lint turf/packages/turf-*/index.js", EDIT: I tryed and it works only if ran directly ( |
👍 We should include this documentation linting. @stebogit we can also use the "lint": "eslint packages",
"postlint": "documentation lint packages/turf-*/index.js", I'm getting warnings (which = as errors in TravisCI), but these seem pretty easy to fix. $ npm run lint
> @4.0.0 lint /Users/mac/Github/turf
> eslint packages
> @4.0.0 postlint /Users/mac/Github/turf
> documentation lint packages/turf-*/index.js
/Users/mac/Github/turf/packages/turf-bbox-polygon/index.js
9:1 warning unknown tag @addToMap
/Users/mac/Github/turf/packages/turf-boolean-contains/index.js
220:1 warning type Boolean found, boolean is standard
/Users/mac/Github/turf/packages/turf-boolean-crosses/index.js
146:1 warning type Boolean found, boolean is standard
/Users/mac/Github/turf/packages/turf-boolean-point-on-line/index.js
38:1 warning type String found, string is standard
/Users/mac/Github/turf/packages/turf-meta/index.js
468:1 warning type object found, Object is standard
741:1 warning unknown tag @turf
760:1 warning unknown tag @turf
/Users/mac/Github/turf/packages/turf-square/index.js
10:1 warning unknown tag @addToMap
⚠ 8 warnings |
Now implemented in TurfJS Core Ref: Turfjs/turf#859
Finally dropped all tests & linting from |
Test
@example
in TurfJS coreGoing to start testing the
@example
directly in TurfJS core, that way we don't have switch back and forth betweenturf-www
&turf
. Used/updated the existing code that was being used inturf-www/test/build.js
.How to use
To-Do
addToMap
validation tests - Publishing updates to TurfJS website turf-www#113 (comment)node test.example
inpackage.json
=>scripts
=>posttest
turf-www
This was suppose to be a PR and not pushed directly to master "Commit 46756c2" (thought I disabled that - guess not 😝)
CC: @stebogit @rowanwins @tmcw @morganherlocker
The text was updated successfully, but these errors were encountered: