-
Notifications
You must be signed in to change notification settings - Fork 944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix license template in create-new-module script #861
Comments
👍 Agreed, might be better to Copy-Paste the LICENSE file instead of hardcoding it. |
@rowanwins Copies the license file now, this script is very rough, but it handles 90% of the module boilerplate. |
Awesome, I'll just test on my machine to make sure the tests pass locally, it might be one of those stupid windows or node version bugs |
@DenisCarriere @rowanwins |
@stebogit Yes it should 👍 |
@rowanwins If that's the case, lets try to figure out what's the issue... I agree it's very annoying going back and forth between Windows/Mac. |
I agree WINDOWS is very annoying! 🤣 😜 |
Running the test at the root level threw an error because my license in my new module wasn't the same as the root license even though I created it using the script. I noticed the script has the license manually hardcoded, perhaps it should be a copy/paste operation? At the moment I can't even tell why it's failing, they look exactly the same to me :)
PS Im on windows, so perhaps there is something in the tests that isn't working on windows...
The text was updated successfully, but these errors were encountered: