Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix license template in create-new-module script #861

Closed
rowanwins opened this issue Jul 22, 2017 · 7 comments
Closed

Fix license template in create-new-module script #861

rowanwins opened this issue Jul 22, 2017 · 7 comments
Assignees
Milestone

Comments

@rowanwins
Copy link
Member

rowanwins commented Jul 22, 2017

Running the test at the root level threw an error because my license in my new module wasn't the same as the root license even though I created it using the script. I noticed the script has the license manually hardcoded, perhaps it should be a copy/paste operation? At the moment I can't even tell why it's failing, they look exactly the same to me :)

PS Im on windows, so perhaps there is something in the tests that isn't working on windows...

@DenisCarriere
Copy link
Member

👍 Agreed, might be better to Copy-Paste the LICENSE file instead of hardcoding it.

@DenisCarriere DenisCarriere added this to the 4.6.0 milestone Jul 23, 2017
@DenisCarriere DenisCarriere self-assigned this Jul 26, 2017
@DenisCarriere
Copy link
Member

@rowanwins Copies the license file now, this script is very rough, but it handles 90% of the module boilerplate.

@rowanwins
Copy link
Member Author

Awesome, I'll just test on my machine to make sure the tests pass locally, it might be one of those stupid windows or node version bugs

@stebogit
Copy link
Collaborator

@DenisCarriere @rowanwins
in README.md shouldn't this be actually # ${camelcaseName}?

@DenisCarriere
Copy link
Member

@stebogit Yes it should 👍

DenisCarriere added a commit that referenced this issue Jul 27, 2017
@DenisCarriere
Copy link
Member

Awesome, I'll just test on my machine to make sure the tests pass locally, it might be one of those stupid windows or node version bugs

@rowanwins If that's the case, lets try to figure out what's the issue... I agree it's very annoying going back and forth between Windows/Mac.

@stebogit
Copy link
Collaborator

I agree WINDOWS is very annoying! 🤣 😜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants