Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug when the number of segments is integer(line-chunk) #1046

Merged
merged 5 commits into from
Oct 27, 2017
Merged

fix bug when the number of segments is integer(line-chunk) #1046

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5314e7c
fix bug when the number of segments is integer
xiongjiabin Oct 26, 2017
6df6333
Merge pull request #1 from xiongjiabin/xiongjiabin-patch-1
xiongjiabin Oct 26, 2017
60df1bb
Update index.js
DenisCarriere Oct 27, 2017
7c2816f
Merge branch 'master' into master
DenisCarriere Oct 27, 2017
55137ce
Removing trailing spaces
DenisCarriere Oct 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/turf-line-chunk/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,13 @@ function sliceLineSegments(line, segmentLength, units, callback) {
// If the line is shorter than the segment length then the orginal line is returned.
if (lineLength <= segmentLength) return callback(line);

var numberOfSegments = Math.floor(lineLength / segmentLength) + 1;
var numberOfSegments = lineLength / segmentLength;

// If numberOfSegments is integer, no need to plus 1
if (!Number.isInteger(numberOfSegments)) {
numberOfSegments = Math.floor(numberOfSegments) + 1;
}

for (var i = 0; i < numberOfSegments; i++) {
var outline = lineSliceAlong(line, segmentLength * i, segmentLength * (i + 1), {units: units});
callback(outline, i);
Expand Down