Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

greaterCircle fix for readme example #1888

Merged

Conversation

chris-catignani
Copy link
Contributor

The example in the greaterCircle readme was not correctly declaring the options.properties object

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Have read How To Contribute.
  • Run npm test at the sub modules where changes have occurred.
  • Run npm run lint to ensure code style at the turf module level.

@@ -6,7 +6,7 @@

Copy link
Contributor Author

@chris-catignani chris-catignani Apr 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was updated when i ran npm run docs, and contains no manual changes

@rowanwins rowanwins self-requested a review May 2, 2020 10:31
Copy link
Member

@rowanwins rowanwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks @chris-catignani !

@rowanwins rowanwins merged commit bf0a3c9 into Turfjs:master May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants