Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of negative distances in transform-translate #1895

Merged
merged 2 commits into from
May 7, 2020
Merged

Fix handling of negative distances in transform-translate #1895

merged 2 commits into from
May 7, 2020

Conversation

rowanwins
Copy link
Member

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Have read How To Contribute.
  • Run npm test at the sub modules where changes have occurred.
  • Run npm run lint to ensure code style at the turf module level.

Fixes a bug in transform-translate where negative distances are handled incorrectly. Added a new test to verify expected behaviour.

Resolves #1451

@rowanwins rowanwins merged commit 0f97326 into master May 7, 2020
@rowanwins rowanwins deleted the transform-translate-fix branch May 7, 2020 03:33
@renovate renovate bot mentioned this pull request Jun 6, 2021
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfedderly mfedderly mfedderly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

transformTranslate must not be used with negative distances
2 participants
@rowanwins @mfedderly