Add support for holes to @turf/mask #2346
Open
+342
−156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @rowanwins. Will try to revive this PR. Would you agree (current behaviour aside) that the default behaviour of mask should be to include holes? That seems most intuitive to me. If you agree will keep the PR as is to maintain existing behaviour, however add a note to default ignoreHoles to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
@turf/maskignores holes. The PR adds an options argument to the operation with anignoreHolesoption, when set tofalseaMultiPolygonis returned with the holes written as outer-rings in the MultiPolygon.npm testat the sub modules where changes have occurred.npm run lintto ensure code style at the turf module level.Resolves #2230