Expose options parameter to @turf/boolean-intersects and @turf/booean-disjoint to add option of ignoring self intersections.

[01100100]

• Use a meaningful title for the pull request. Include the name of the package modified.
• Have read How To Contribute.
• Run npm test at the sub modules where changes have occurred.
• Run npm run lint to ensure code style at the turf module level.

As mentioned in #2633

The @turf/boolean-intersects function does not handle cases when the user wants to ignore self intersections.

This PR introduces the changes needed to accommodate the options.ignoreSelfIntersections parameter.

MODIFIED PACKAGES:

• boolean-disjoint
• boolean-intersects

The changes are backwards compatible.

I would like to include some extra tests for the new cases, but not sure how to best add/structure tests for this optional parameter, given the current setup https://github.com/Turfjs/turf/blob/master/packages/turf-boolean-intersects/test.ts#L9

Below is an example of a lineString containing a self intersection, that might be useful for testing the changes introduced in the PR.

{
  "type": "Feature",
  "properties": {},
  "geometry": {
    "type": "LineString",
    "coordinates": [
      [
        1,
        1
      ],
      [
        2,
        2
      ],
      [
        1,
        2
      ],
      [
        2,
        1
      ]
    ]
  }
}

[smallsaucepan]

Thanks heaps for putting this together @01100100. Before we look to merge, could you please add a couple of tests to cover passing true, false or empty for this new option?

[01100100]

@smallsaucepan added the test cases and checked they all passed as expected 👍

Let me know if there is anything else that this PR needs!

[01100100]

Hi @smallsaucepan and other maintainers 👋

Anything I can do to help this getting merged and in a release? I have a monkey patched 🐒 🔧 version of this function working in a project, and would like to use turf.js without modifying it. Happy to help if something else needs to be done here 😄

[smallsaucepan]

Thanks for following up @01100100. Also added some review comments on boolean-disjoint/index.ts about tightening up the types. Do those show up for you?

[01100100]

They don't seem to show up anywhere. Where can I find them? Sorry if I am looking in the wrong place?

[smallsaucepan]

My apologies. I had added comments but they were only "pending". Please see if they're visible now.

[01100100]

All good 😄 I can see them now, will have a look later and ping you when I am done. Thanks and have a good one!

[01100100]

Hi @smallsaucepan + others,

Just chasing this up as its still open. Is there anything else that needs to be done? Would be more then happy to help

[smallsaucepan]

Hi @01100100. I've got an alternative way to do the options passing. You mind if I push a commit to your branch to demonstrate?

[01100100]

Hi @smallsaucepan

Yes please do! I would appreciate seeing a nice way to do this

[smallsaucepan]

@01100100 changed tack slightly with the options, so instead we pass ignoreSelfIntersections around internally as a boolean, and only worry about checking / packaging is as an options object when viewed from the outside. Let me know if you think that works and we can press on.

[01100100]

Hi @smallsaucepan,

That is a much more concise way of doing it. Thanks for sharing. Works for me and happy if its merged 😄

[coracuity]

I ran into this yesterday upgrading to 7.0, I'm very excited for this to be merged/released!

[01100100]

Hi @smallsaucepan,

Let me know if you need anything more done here and thanks for maintaining this project!

Regards,
Dave

[smallsaucepan]

Thanks for working through this with us @01100100.