-
Notifications
You must be signed in to change notification settings - Fork 9
Implement varname prefix / unprefix #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #119 +/- ##
==========================================
- Coverage 92.30% 90.93% -1.37%
==========================================
Files 2 2
Lines 247 298 +51
==========================================
+ Hits 228 271 +43
- Misses 19 27 +8 ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 13652741018Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Only minor concern is that the tests seem to overlap with doctests, might still worth keeping, but I just thought to mention this
It is, I did notice it too. :( Do you have any idea what's the best thing to do? Feels bad to remove the tests, but we do also want to document the behaviour. |
From my end, I think it okay to keep both |
Closes #117
This will eventually be needed for submodel stuff.