Skip to content

Implement varname prefix / unprefix #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 4, 2025
Merged

Implement varname prefix / unprefix #119

merged 6 commits into from
Mar 4, 2025

Conversation

penelopeysm
Copy link
Member

@penelopeysm penelopeysm commented Mar 4, 2025

Closes #117

This will eventually be needed for submodel stuff.

Copy link

codecov bot commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 84.31373% with 8 lines in your changes missing coverage. Please review.

Project coverage is 90.93%. Comparing base (700a70b) to head (b10bd1b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/varname.jl 84.31% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
- Coverage   92.30%   90.93%   -1.37%     
==========================================
  Files           2        2              
  Lines         247      298      +51     
==========================================
+ Hits          228      271      +43     
- Misses         19       27       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Mar 4, 2025

Pull Request Test Coverage Report for Build 13652741018

Details

  • 40 of 51 (78.43%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.4%) to 90.94%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/varname.jl 40 51 78.43%
Totals Coverage Status
Change from base Build 13229542274: -1.4%
Covered Lines: 271
Relevant Lines: 298

💛 - Coveralls

@penelopeysm penelopeysm requested a review from sunxd3 March 4, 2025 11:45
Copy link
Member

@sunxd3 sunxd3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Only minor concern is that the tests seem to overlap with doctests, might still worth keeping, but I just thought to mention this

@penelopeysm
Copy link
Member Author

It is, I did notice it too. :( Do you have any idea what's the best thing to do? Feels bad to remove the tests, but we do also want to document the behaviour.

@sunxd3
Copy link
Member

sunxd3 commented Mar 4, 2025

From my end, I think it okay to keep both

@penelopeysm penelopeysm merged commit c094f3a into main Mar 4, 2025
8 of 10 checks passed
@penelopeysm penelopeysm deleted the py/prefix branch March 4, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prefixing & unprefixing varnames should go here
3 participants