Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract resampling methods #15

Merged
merged 1 commit into from
Dec 2, 2020
Merged

Extract resampling methods #15

merged 1 commit into from
Dec 2, 2020

Conversation

devmotion
Copy link
Member

This PR extracts and tests the resampling methods.

@devmotion
Copy link
Member Author

In my opinion, in a subsequent PR they should be changed to include explicit RNGs (somehow this is still missing...). I just wanted to only extract things in this PR.

@coveralls
Copy link

coveralls commented Dec 2, 2020

Pull Request Test Coverage Report for Build 396052745

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 41 of 55 (74.55%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+14.0%) to 14.047%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/resampling.jl 41 55 74.55%
Files with Coverage Reduction New Missed Lines %
src/container.jl 1 0.0%
Totals Coverage Status
Change from base Build 392069529: 14.0%
Covered Lines: 42
Relevant Lines: 299

💛 - Coveralls

@codecov
Copy link

codecov bot commented Dec 2, 2020

Codecov Report

Merging #15 (0ff041a) into master (143b580) will increase coverage by 14.04%.
The diff coverage is 74.54%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #15       +/-   ##
===========================================
+ Coverage    0.00%   14.04%   +14.04%     
===========================================
  Files           2        4        +2     
  Lines         303      299        -4     
===========================================
+ Hits            0       42       +42     
+ Misses        303      257       -46     
Impacted Files Coverage Δ
src/AdvancedPS.jl 100.00% <ø> (ø)
src/container.jl 0.00% <ø> (ø)
src/smc.jl 0.00% <ø> (ø)
src/resampling.jl 74.54% <74.54%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 143b580...e674961. Read the comment docs.

Copy link
Member

@yebai yebai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks all good! Happy to merge as-is given that there are no functional changes.

@yebai yebai merged commit f1bdb24 into master Dec 2, 2020
@delete-merged-branch delete-merged-branch bot deleted the resampling branch December 2, 2020 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants