Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Turing/src/contrib/inference/AdvancedSMCExtensions.jl to src/c… #16

Merged
merged 1 commit into from
Dec 2, 2020

Conversation

yebai
Copy link
Member

@yebai yebai commented Dec 2, 2020

…ontrib/AdvancedSMCExtensions.jl

@coveralls
Copy link

Pull Request Test Coverage Report for Build 396107135

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-4.6%) to 9.438%

Totals Coverage Status
Change from base Build 396098184: -4.6%
Covered Lines: 42
Relevant Lines: 445

💛 - Coveralls

@codecov
Copy link

codecov bot commented Dec 2, 2020

Codecov Report

Merging #16 (2acdbc0) into master (f1bdb24) will decrease coverage by 4.60%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #16      +/-   ##
=========================================
- Coverage   14.04%   9.43%   -4.61%     
=========================================
  Files           4       5       +1     
  Lines         299     445     +146     
=========================================
  Hits           42      42              
- Misses        257     403     +146     
Impacted Files Coverage Δ
src/contrib/AdvancedSMCExtensions.jl 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1bdb24...2acdbc0. Read the comment docs.

Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file is not very useful currently though, it seems to be based on an earlier iteration of Turing (maybe even before AbstractMCMC existed?).

@yebai
Copy link
Member Author

yebai commented Dec 2, 2020

The file is not very useful currently though, it seems to be based on an earlier iteration of Turing (maybe even before AbstractMCMC existed?).

yes, we kept algorithms in this file as add-on features while @cpfiffer was transferring Turing into the AbstractMCMC interface. Maybe we can keep the file as-is and decide whether to adapt/remove it later?

@devmotion
Copy link
Member

Sure, I just wanted to point out that it's not really properly integrated like the other files, neither here nor in Turing. But my intention when transferring it from Turing was also that at some point it could be updated.

@yebai yebai merged commit 0ca372d into master Dec 2, 2020
@delete-merged-branch delete-merged-branch bot deleted the hg/move-file branch December 2, 2020 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants