Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RNG to resampling methods #19

Merged
merged 3 commits into from
Dec 5, 2020
Merged

Add RNG to resampling methods #19

merged 3 commits into from
Dec 5, 2020

Conversation

devmotion
Copy link
Member

No description provided.

@@ -1,11 +1,12 @@
name = "AdvancedPS"
uuid = "576499cb-2369-40b2-a588-c64705576edc"
authors = ["TuringLang"]
version = "0.1.0"
version = "0.2.0"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Officially, this is not breaking since currently nothing is exported. However, I know that this will break Turing since we call some of the internal methods without RNG, so I thought it would be safer to declare it as breaking.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 401885214

  • 4 of 18 (22.22%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 25.943%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/container.jl 1 7 14.29%
src/resampling.jl 3 11 27.27%
Totals Coverage Status
Change from base Build 398955753: 0.06%
Covered Lines: 110
Relevant Lines: 424

💛 - Coveralls

@codecov
Copy link

codecov bot commented Dec 5, 2020

Codecov Report

Merging #19 (4555653) into master (c87cba7) will increase coverage by 0.06%.
The diff coverage is 22.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
+ Coverage   25.88%   25.94%   +0.06%     
==========================================
  Files           5        5              
  Lines         425      424       -1     
==========================================
  Hits          110      110              
+ Misses        315      314       -1     
Impacted Files Coverage Δ
src/AdvancedPS.jl 100.00% <ø> (ø)
src/container.jl 62.72% <14.28%> (ø)
src/resampling.jl 75.47% <27.27%> (+1.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c87cba7...fbea67e. Read the comment docs.

Copy link
Member

@yebai yebai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@yebai yebai merged commit 487a943 into master Dec 5, 2020
@delete-merged-branch delete-merged-branch bot deleted the resampling_rng branch December 5, 2020 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants