Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving test coverage #69

Merged
merged 7 commits into from
Oct 31, 2022
Merged

Improving test coverage #69

merged 7 commits into from
Oct 31, 2022

Conversation

FredericWantiez
Copy link
Member

Given all the changes on master that happened recently it would be good to improve the coverage a bit, especially on the PGAS and TracedRNG parts.

test/container.jl Outdated Show resolved Hide resolved
test/pgas.jl Outdated Show resolved Hide resolved
test/pgas.jl Outdated Show resolved Hide resolved
@FredericWantiez
Copy link
Member Author

I plan to add more tests after this. This is mainly to clean up and remove TArray references

@coveralls
Copy link

coveralls commented Oct 29, 2022

Pull Request Test Coverage Report for Build 3353044103

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+31.4%) to 96.306%

Totals Coverage Status
Change from base Build 3353037959: 31.4%
Covered Lines: 365
Relevant Lines: 379

💛 - Coveralls

@codecov
Copy link

codecov bot commented Oct 29, 2022

Codecov Report

Base: 64.94% // Head: 96.30% // Increases project coverage by +31.36% 🎉

Coverage data is based on head (7905882) compared to base (c99f920).
Patch has no changes to coverable lines.

❗ Current head 7905882 differs from pull request most recent head 455c2a4. Consider uploading reports for the commit 455c2a4 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master      #69       +/-   ##
===========================================
+ Coverage   64.94%   96.30%   +31.36%     
===========================================
  Files           7        6        -1     
  Lines         542      379      -163     
===========================================
+ Hits          352      365       +13     
+ Misses        190       14      -176     
Impacted Files Coverage Δ
src/rng.jl 90.00% <ø> (-0.33%) ⬇️
src/smc.jl 98.07% <0.00%> (+25.52%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

src/rng.jl Show resolved Hide resolved
@yebai yebai merged commit 118e45e into master Oct 31, 2022
@yebai yebai deleted the fred/tests branch October 31, 2022 20:08
@yebai
Copy link
Member

yebai commented Oct 31, 2022

thanks, @FredericWantiez - I'll merge this PR so we can finalise the Turing update. Please feel free to open another PR for more tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants