implement suggestions

src/bijectors/truncated.jl

@@ -68,26 +68,23 @@ end
 
 with_logabsdet_jacobian(b::TruncatedBijector, x) = transform(b, x), logabsdetjac(b, x)
 
-# from stan https://github.com/stan-dev/math/blob/develop/stan/math/prim/constraint/lub_constrain.hpp etc
-function truncated_inv_logabsdetjac(x, a, b)
+function truncated_inv_logabsdetjac(y, a, b)
  lowerbounded, upperbounded = isfinite(a), isfinite(b)
  if lowerbounded && upperbounded
- return log(b - a) - abs(x) + 2.0 * LogExpFunctions.log1pexp(-abs(x))
- elseif lowerbounded
- return x
- elseif upperbounded
- return x
+ return log(b - a) - abs(y) + 2 * LogExpFunctions.log1pexp(-abs(y))
+ elseif lowerbounded || upperbounded
+ return convert(promote_type(typeof(y), typeof(a), typeof(b)), y)
  else
- return zero(x)
+ return zero(y)
  end
 end
 
-function logabsdetjac(ib::Inverse{<:TruncatedBijector}, x)
+function logabsdetjac(ib::Inverse{<:TruncatedBijector}, y)
  a, b = ib.orig.lb, ib.orig.ub
- return truncated_inv_logabsdetjac.(x, a, b)
+ return truncated_inv_logabsdetjac.(y, a, b)
 end
 
-with_logabsdet_jacobian(ib::Inverse{<:TruncatedBijector}, x) = transform(ib, x), logabsdetjac(ib, x)
+with_logabsdet_jacobian(ib::Inverse{<:TruncatedBijector}, y) = transform(ib, y), logabsdetjac(ib, y)
 
 # It's only monotonically decreasing if it's only upper-bounded.
 # In the multivariate case, we can only say something reasonable if entries are monotonic.