added explicit implementation of with_logabsdet_jacobian for PDBijector

TuringLang · Aug 4, 2023 · 83fee94 · 83fee94
1 parent 94f6a0e
commit 83fee94
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/src/bijectors/pd.jl b/src/bijectors/pd.jl
@@ -26,10 +26,9 @@ function logabsdetjac_pdbijector_chol(X::AbstractMatrix)
  return -(z + d * oftype(z, IrrationalConstants.logtwo))
 end
 
-# TODO: Implement explicitly.
 function with_logabsdet_jacobian(b::PDBijector, X)
- U = cholesky_upper(X)
- return replace_diag(log, U), logabsdetjac_pdbijector_chol(U)
+ L = cholesky_lower(X)
+ return replace_diag(log, L), logabsdetjac_pdbijector_chol(L)
 end
 
 struct PDVecBijector <: Bijector end