Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update FillArrays compat to 1.4.1 #251

Merged
merged 3 commits into from
Jul 17, 2023
Merged

Update FillArrays compat to 1.4.1 #251

merged 3 commits into from
Jul 17, 2023

Conversation

devmotion
Copy link
Member

Closes #248.

@devmotion devmotion mentioned this pull request Jul 11, 2023
Merged
@devmotion
Copy link
Member Author

devmotion commented Jul 11, 2023 •
edited
Loading

Seems the final commit that fixed type inference broke ReverseDiff. AD and broadcasting is.... annoying.

@devmotion
Copy link
Member Author

Possibly fixed by JuliaArrays/FillArrays.jl#278, let's see.

@devmotion devmotion changed the title Update FillArrays compat to 1.4.0 Update FillArrays compat to 1.4.1 Jul 17, 2023
@yebai yebai merged commit 833e876 into master Jul 17, 2023
14 of 15 checks passed
@delete-merged-branch delete-merged-branch bot deleted the devmotion-patch-1 branch July 17, 2023 18:01
@yebai
Copy link
Member

yebai commented Jul 17, 2023

Many thanks @devmotion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devmotion @yebai