-
Notifications
You must be signed in to change notification settings - Fork 37
Remove NodeTrait
#1133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove NodeTrait
#1133
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## breaking #1133 +/- ##
============================================
- Coverage 81.48% 81.32% -0.16%
============================================
Files 40 40
Lines 3845 3807 -38
============================================
- Hits 3133 3096 -37
+ Misses 712 711 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Benchmark Report for Commit e54d3c3Computer InformationBenchmark Results |
|
DynamicPPL.jl documentation for PR #1133 is available at: |
mhauru
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, happy about the simplification.
Instead of using
NodeTrait, this PR usesAbstractParentContext.I think the changelogs and docs explain the interesting bits. Most of the code changes are just tedium.
Closes #1052.