[Merged by Bors] - Re-opening of #310 #330
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…/DynamicPPL.jl into tor/allow-non-array-variables
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Seems like now that Bijectors.jl isn't holding ChainRules back, we're finally running on ChainRules@1 and things are not working correctly 😕 |
|
Do you recognize this bug @devmotion ? I haven't looked too much into CRC1 yet. |
|
Seems to involve generators, so maybe similar to the issues that we saw with CRC and Zygote in TuringLang/DistributionsAD.jl#198 and TuringLang/DistributionsAD.jl#197 🤷 |
|
bors try |
|
Tests will only pass when the relevant Zygote PR with the fix is merged and released. |
tryMerge conflict. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…cPPL.jl into tor/submodels-hotfixes
|
@torfjelde let's also try to merge this PR before making a new release. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
bors r+ |
|
Pull request successfully merged into master. Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We forgot to merge the #310 before merging #295.