Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for EnzymeCore to 0.8 for package test, (keep existing compat) #665

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the EnzymeCore package from 0.6, 0.7 to 0.6, 0.7, 0.8 for package test.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@github-actions github-actions bot force-pushed the compathelper/new_version/2024-09-19-00-11-02-076-03785080672 branch from 97b4dfe to d2212d7 Compare September 19, 2024 00:11
@yebai
Copy link
Member

yebai commented Sep 19, 2024

@penelopeysm, is there any way you can safely permit CI on these automatically created PRs?

@penelopeysm
Copy link
Member

No, not really – we'd have to create a personal access token and add it to the CompatHelper workflow, which I think is not really safe.

Other places I've seen that do this use a GitHub app (such as Dependabot) to manage this, which works because the app has its own token that can be used to trigger workflows.

@yebai
Copy link
Member

yebai commented Sep 19, 2024

Can you ask the Julia community to see the standard method for addressing this? If we can't find a better solution, then feel free to add a personal access token to CompatHelper.

@penelopeysm
Copy link
Member

JuliaRegistries/CompatHelper.jl#500 suggests the current workaround is to close and reopen the PR... let's see

add a personal access token to CompatHelper

It'd be a token associated with my account, and it would mean that anybody in the organisation can use it, though. We'd need to find a volunteer brave enough to provide the token but that's not me :)

@penelopeysm penelopeysm reopened this Sep 19, 2024
@penelopeysm
Copy link
Member

It's weird that setting the ssh key in COMPATHELPER_PRIV doesn't work. Documenter also uses an ssh key and it works well enough. I think this is an upstream bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants