Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant code #168

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Remove redundant code #168

merged 1 commit into from
Aug 2, 2023

Conversation

willtebbutt
Copy link
Member

Resolves #166

yebai
yebai approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@yebai yebai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @willtebbutt!

@willtebbutt
Copy link
Member Author

Np. Will merge when CI passes

@willtebbutt
Copy link
Member Author

Test failures are due to known existing failure that will be fixed when the subtape branch is merged in, so I'm going to go ahead and merge.

@willtebbutt
Copy link
Member Author

Apparently I can't merge. @yebai could you please merge when you get a minute.

@yebai
Copy link
Member

yebai commented Aug 2, 2023

@willtebbutt Can you try again?

@willtebbutt willtebbutt merged commit 203df3f into master Aug 2, 2023
17 of 18 checks passed
@willtebbutt willtebbutt deleted the wct/remove-unused-benchmarks branch August 2, 2023 21:46
@willtebbutt
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yebai yebai yebai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redundant Code?
2 participants
@willtebbutt @yebai