Skip to content

TArray Indexing Performance #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jan 28, 2021
Merged

TArray Indexing Performance #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
c8af0f4
improve TArray benchmarks
Jan 5, 2021
fd4abd6
update benchmarks
Jan 7, 2021
ba7d533
1. Base.@propagate_inbounds, 2. use function in benchmarks
Jan 7, 2021
cf3bbaf
optimize indexing for Matrix{Float64}
Jan 12, 2021
3f9c6e7
indent code
Jan 12, 2021
f1f9e6d
move TArray data into TArray
Jan 13, 2021
694c23e
update benchmarks
Jan 13, 2021
f0a8179
update comments and fix other issues
Jan 14, 2021
13489c8
more performant way to perdicate if a weakref is empty
Jan 14, 2021
ea7fbc5
underlying array type as a parametric type of TArray
Jan 14, 2021
6e192db
minor update
Jan 14, 2021
aaf00d2
update according to code review
Jan 26, 2021
bddfc26
fix broadcasting
Jan 27, 2021
ad7ee12
Update Project.toml
yebai Jan 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ uuid = "6f1fad26-d15e-5dc8-ae53-837a1d7b8c9f"
license = "MIT"
desc = "C shim for task copying in Turing"
repo = "https://github.com/TuringLang/Libtask.jl.git"
version = "0.5.1"
version = "0.5.2"

[deps]
Libtask_jll = "3ae2931a-708c-5973-9c38-ccf7496fb450"
Expand Down
9 changes: 7 additions & 2 deletions src/ctask.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,10 @@ struct CTask
task::Task

function CTask(task::Task)
new(enable_stack_copying(task))
ret = new(enable_stack_copying(task))
task.storage === nothing && (task.storage = IdDict())
task.storage[:ctask] = ret
ret
end
end

Expand All @@ -24,12 +27,13 @@ end

function Base.showerror(io::IO, ex::CTaskException)
println(io, "CTaskException:")
ct = ex.task
bt = @static if VERSION < v"1.6.0-DEV.1145"
ct.backtrace
else
ct.storage[:_libtask_bt]
end
showerror(io, ex.task.exception, bt)
showerror(io, ct.exception, bt)
end

# Utility function for self-copying mechanism
Expand Down Expand Up @@ -107,6 +111,7 @@ function Base.copy(ctask::CTask)
setstate!(newtask, getstate(task))
newtask.result = task.result

copy_tarrays(task, newtask)
return CTask(newtask)
end

Expand Down
Loading