Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft DA script #57

Draft
wants to merge 26 commits into
base: main
Choose a base branch
from
Draft

Draft DA script #57

wants to merge 26 commits into from

Conversation

FredericWantiez
Copy link
Member

No description provided.

Copy link
Collaborator

@charlesknipp charlesknipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely stellar demonstration, data assimilation is such a good example. Also those 3D plots are so cool

SSMProblems = "26aad666-b158-4e64-9d35-0e672562fa48"
StaticArrays = "90137ffa-7385-5640-81b9-e52037218182"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure this is just left over from some experimentation. Did you try running anything with StaticArrays?

end

function SSMProblems.distribution(obs::ObservationNoiseProcess, step::Integer, state, extra)
return MvNormal(state, obs.σ * I)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the importance of having the identity matrix in obs.σ * I?

Copy link
Member Author

@FredericWantiez FredericWantiez Oct 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's redundant, obs.σ is already a PDMat. Didn't catch that

lineage = get_ancestry(sparse_ancestry.tree)

# Fancy 3D plot
# fig = Figure()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm obsessed with this plot

Base automatically changed from ck/particle-methods to main October 21, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants