-
Notifications
You must be signed in to change notification settings - Fork 231
Bump DynamicPPL.jl, AdvancedVI, and Bijectors version #1979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 4735955139
💛 - Coveralls |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #1979 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 21 21
Lines 1422 1424 +2
======================================
- Misses 1422 1424 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
…ing.jl into torfjelde/dynamicppl-bump
|
Excellent PR -- thanks @torfjelde! |
|
|
||
| Turing.setrdcache(false) | ||
| for adbackend in (:forwarddiff, :tracker, :reversediff) | ||
| for adbackend in (:forwarddiff, :reversediff) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@torfjelde I just noticed this change - this seems quite dangerous because things might start breaking silently without us noticing it while still stating officially in the package (compat entry, docs etc.) that Tracker is supported.
So I think in case this is the official policy (which IMO is a bit sad because Tracker is quite stable, much simpler than ReverseDiff or Zygote, and started to receive updates more frequently again) then IMO it should be removed from the package, docs, etc., ideally before removing tests for it.
What the title says
Warning: this PR also removes testing of Tracker.jl. Tracker.jl is the only AD backend requiring custom rules (i.e. isn't supported by ChainRules.jl) and hence requires quite a bit of additional developer effort to maintain and test throughout the TuringLang ecosystem. It seems to me that this is no longer worth the effort given how little (if any) use Tracker.jl sees.