Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for FillArrays to 1, (keep existing compat) #2017

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jun 20, 2023

This pull request changes the compat entry for the FillArrays package from =1.0.0 to =1.0.0, 1.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

Fix #2029

@cpfiffer cpfiffer force-pushed the compathelper/new_version/2023-06-20-00-28-10-425-02951265853 branch from d37d5e6 to 0a1b080 Compare June 20, 2023 00:28
@github-actions
Copy link
Contributor Author

github-actions bot commented Jun 20, 2023

Pull Request Test Coverage Report for Build 5458464522

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 299 unchanged lines in 4 files lost coverage.
  • Overall coverage remained the same at 0.0%

Files with Coverage Reduction New Missed Lines %
src/inference/gibbs.jl 36 0%
src/modes/ModeEstimation.jl 66 0%
src/inference/Inference.jl 92 0%
src/inference/hmc.jl 105 0%
Totals Coverage Status
Change from base Build 5313671228: 0.0%
Covered Lines: 0
Relevant Lines: 1426

💛 - Coveralls

@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (970abac) 0.00% compared to head (2947319) 0.00%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2017   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files          21      21           
  Lines        1427    1426    -1     
======================================
+ Misses       1427    1426    -1     

see 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

… existing compat) (#2019)

Co-authored-by: CompatHelper Julia <compathelper_noreply@julialang.org>
@devmotion
Copy link
Member

I'm quite certain that this is still not fixed upstream: JuliaArrays/FillArrays.jl#252 FillArrays > 1.0.0 breaks ReverseDiff and Tracker.

@yebai yebai deleted the compathelper/new_version/2023-06-20-00-28-10-425-02951265853 branch July 17, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant