Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update FillArrays compat to 1.4.1 #2035

Merged
merged 5 commits into from
Jul 17, 2023
Merged

Update FillArrays compat to 1.4.1 #2035

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
769dcdf
Update FillArrays compat to 1.4.0
devmotion Jul 11, 2023
0378d28
Update test compat
devmotion Jul 11, 2023
f8c3377
Try to enable ReverseDiff tests
devmotion Jul 11, 2023
24e1417
Update Project.toml
devmotion Jul 17, 2023
f9f3cf3
Update Project.toml
devmotion Jul 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "Turing"
uuid = "fce5fe82-541a-59a6-adf8-730c64b5f9a0"
version = "0.26.3"
version = "0.26.4"

[deps]
AbstractMCMC = "80f14c24-f653-4e6a-9b94-39d6b0f70001"
Expand Down Expand Up @@ -50,7 +50,7 @@ DistributionsAD = "0.6"
DocStringExtensions = "0.8, 0.9"
DynamicPPL = "0.23"
EllipticalSliceSampling = "0.5, 1"
FillArrays = "=1.0.0"
FillArrays = "1.4.0"
ForwardDiff = "0.10.3"
Libtask = "0.7, 0.8"
LogDensityProblems = "2"
Expand Down
2 changes: 1 addition & 1 deletion test/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ Distributions = "0.25"
DistributionsAD = "0.6.3"
DynamicHMC = "2.1.6, 3.0"
DynamicPPL = "0.23"
FillArrays = "=1.0.0"
FillArrays = "1.4.0"
FiniteDifferences = "0.10.8, 0.11, 0.12"
ForwardDiff = "0.10.12 - 0.10.32, 0.10"
LogDensityProblems = "2"
Expand Down
9 changes: 4 additions & 5 deletions test/essential/ad.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,15 +95,14 @@
sample(dir(), HMC(0.01, 1), 1000)
Turing.setrdcache(false)
end
# FIXME: For some reasons PDMatDistribution AD tests fail with ReverseDiff
@testset "PDMatDistribution AD" begin
@model function wishart()
theta ~ Wishart(4, Matrix{Float64}(I, 4, 4))
end
Turing.setadbackend(:tracker)
sample(wishart(), HMC(0.01, 1), 1000);
#Turing.setadbackend(:reversediff)
#sample(wishart(), HMC(0.01, 1), 1000);
Turing.setadbackend(:reversediff)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why ReverseDiff is working on these tests now?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, difficult to tell since it hasn't been tested for a long time.

Copy link
Member

@torfjelde torfjelde Jul 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also came across these not too long ago due to the changes we've been making in Bijectors. I think it might just be due to TuringLang/Bijectors.jl#246 which added these lines: https://github.com/TuringLang/Bijectors.jl/blob/9cd59070871cc7a29df0e401a24a08502241b230/ext/BijectorsReverseDiffExt.jl#L256-L259

sample(wishart(), HMC(0.01, 1), 1000);
Turing.setadbackend(:zygote)
sample(wishart(), HMC(0.01, 1), 1000);

Expand All @@ -112,8 +111,8 @@
end
Turing.setadbackend(:tracker)
sample(invwishart(), HMC(0.01, 1), 1000);
#Turing.setadbackend(:reversediff)
#sample(invwishart(), HMC(0.01, 1), 1000);
Turing.setadbackend(:reversediff)
sample(invwishart(), HMC(0.01, 1), 1000);
Turing.setadbackend(:zygote)
sample(invwishart(), HMC(0.01, 1), 1000);
end
Expand Down