Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant code in hmc.jl #2357

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Remove redundant code in hmc.jl #2357

merged 1 commit into from
Oct 2, 2024

Conversation

sunxd3
Copy link
Member

@sunxd3 sunxd3 commented Oct 1, 2024

The removed lines should be covered by the combination of

getstats(transition::AdvancedHMC.Transition) = transition.stat
and
function Transition(model::DynamicPPL.Model, vi::AbstractVarInfo, t)
θ = getparams(model, vi)
lp = getlogp(vi)
return Transition(θ, lp, getstats(t))
end

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.83%. Comparing base (3c91eec) to head (b3a13a1).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2357      +/-   ##
==========================================
- Coverage   86.86%   86.83%   -0.04%     
==========================================
  Files          24       24              
  Lines        1599     1595       -4     
==========================================
- Hits         1389     1385       -4     
  Misses        210      210              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11124105939

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 87.052%

Totals Coverage Status
Change from base Build 11050401755: -0.03%
Covered Lines: 1385
Relevant Lines: 1591

💛 - Coveralls

@sunxd3 sunxd3 requested review from torfjelde, mhauru and yebai October 1, 2024 14:27
@sunxd3 sunxd3 merged commit 9a97dfe into master Oct 2, 2024
62 checks passed
@sunxd3 sunxd3 deleted the remove_redundancy branch October 2, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants