-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to docs infrastructure #497
Conversation
Preview the changes: https://turinglang.org/docs/pr-previews/497 |
Unfortunately, GitHub is still running the version of the workflows on the main branch, so the current PR preview doesn't show the correctly built docs (for example, it still has the To get around this, I'm going to temporarily add a new workflow file that runs on this branch, then remove it after it's done running. Edit: The workflow ran at: https://github.com/TuringLang/docs/actions/runs/10131613167/job/28014548724?pr=497 and the preview docs now reflect the docs that would be built if this PR were merged. |
7cbb93c
to
6a380d5
Compare
The action now: - runs on all PRs to main / backport branches - runs on pushes to main / backport branches It always checks that the version of Turing in Project.toml matches that in _quarto.yml. Additionally, if the PR is targeted at main / the push is to the main branch, it also checks that the version of Turing matches the latest release on GitHub.
6a380d5
to
40e6e13
Compare
(@shravanngoswamii Requesting your expertise on github actions here :)) |
Actually, we created the backport of v0.32 because it was released when I was developing versions workflows for this repo! gh-pages: https://github.com/TuringLang/docs/tree/gh-pages/versions |
In current workflow, we have to create a branch from some old commit and then update the old docs by changing version number in _quarto.yml |
Yeah. I think we are agreeing, right? ;) The docs for v0.33 would live in a v0.33 branch (we can call it backport-v0.33 for consistency, or we can take a different name, not a big deal). The |
Is it fine to create a lot of branches, because they will keep increasing! |
Personally I wouldn't have a problem with it! As long as we are publishing multiple versions of the docs online, the source for those versions will have to live somewhere, and this repo is the most logical place to house them. Most software projects I know do this too, for example the Julia core repo has release/vX.Y branches with all the docs which (I presume) is how they keep docs for old versions online :) If we find one day that there are too many branches, then we could just stop providing online documentation for old versions. For example, we could say that we provide docs only for the 5 latest versions. We could discuss that in the future, but I can't say I feel particularly bad about using GitHub's disk space haha. |
Well, I agree to all your points! I am approving changes from my side! Maybe @yebai would like to review it before merging! |
@penelopeysm Thank you for all the effort!! |
@mhauru can you take a look too, and approve before merging? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a few questions and small comments, seems great. That auto-version-updater GHA is faaancy! I wonder if the Julia code for it could live in a .jl
file somewhere. Having that much Julia code as a string in yaml feels funny, and exempts it from things like linting.
7794371
to
331ec13
Compare
331ec13
to
ea236c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks Penny!
Thanks everyone! |
Namely, using a single environment for the project. This ensures that this branch plays well with the GitHub workflow.
venv
and.venv
paths)Please see issues for more details!