-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use standard build system #6
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you ;) I'll do two or three tests (should be fine because it's you :p) then merge this PR this WE -- I don't really have time to do dev stuff this week. |
Nevermind, had a dozen of minutes to test it today; it's in fact easier than using CMake (here). Some minor issues:
|
Thanks a lot :D. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the cmake based build system with a standardised devkitPro Makefile which means that people can build it without installing cmake.
There's still a need to obtain makerom and bannertool but these should not be placed in the $DEVKITARM/bin folder and I'd appreciate it if build instructions didn't encourage people to place anything at all within the toolchain folders. We're currently looking into providing some tools to generate CIAs but that's going to be a little while yet.