Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance macos detection when use gnu functions #136

Open
monsieurchico opened this issue May 13, 2014 · 4 comments
Open

Enhance macos detection when use gnu functions #136

monsieurchico opened this issue May 13, 2014 · 4 comments
Assignees
Labels

Comments

@monsieurchico
Copy link
Contributor

On mac os, when you use gnu-sed, gnu-grep, etc.. the tool call theses functions like we were using regular mac os functions.
I think we should catch the error when it is the case and try to execute the linux equivalent after.
Moreover, macos seems not to like declare -A CUI_COLORS(.

@monsieurchico monsieurchico self-assigned this May 13, 2014
@monsieurchico
Copy link
Contributor Author

@geoffroy-aubry is it ok if I create a hotfix for this ?

@geoffroy-aubry
Copy link
Member

OK for hotfix, but don't close it before an external reviewing :-)

monsieurchico added a commit that referenced this issue Aug 7, 2014
@monsieurchico
Copy link
Contributor Author

So I decided to base the os compatibility functions on error codes instead of os detection.
we saw that on some cases (for instance mac os + gnutls extension) the os detection is not relevant.

@geoffroy-aubry
Copy link
Member

Travis CI build failed :-/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants