Feature start from release #169
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1292,7 +1292,7 @@ function displayQuotedEnum () { | |||
| if [ -z "$trimmed_list" ]; then | |||
| echo | |||
| else | |||
| local quoted_list="'<b>${trimmed_list// /</b>', '<b>}</b>'" | |||
| local quoted_list="'<b>${trimmed_list// /</b>\', \'<b>}</b>'" | |||
There was a problem hiding this comment.
Sorry, I don't understand the reason. And these escaped quotes failed unit tests: https://travis-ci.org/Twenga/twgit/builds/205628394#L166
There was a problem hiding this comment.
I have counter-commit this line to pass the rest of the pull request.
There was a problem hiding this comment.
Okay, maybe this point needs more investigations. In my environment, the tests don't pass because the quotes disappear. For example, a twgit feature list prints:
/!\ Following branches are out of process: 'origin/rm-1, origin/rm-2, origin/rm-3'!
I am on Ubuntu 16.04 with bash version 4.3.46(1)-release (x86_64-pc-linux-gnu).
|
Thanks a lot for this interesting contribution! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 'demo start from-release' and 'feature start from-release', and improve bash completion.