Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(config): replace hostname in error string if opted #262

Merged
merged 1 commit into from
Mar 16, 2022
Merged

fix(config): replace hostname in error string if opted #262

merged 1 commit into from
Mar 16, 2022

Conversation

shashank68
Copy link
Contributor

@shashank68 shashank68 commented Mar 15, 2022 •
edited
Loading

TwiN
TwiN approved these changes Mar 16, 2022
View reviewed changes
Copy link
Owner

@TwiN TwiN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shashank68 Thank you for the contribution!

@TwiN TwiN changed the title core: replace hostname in error string if opted fix(config): replace hostname in error string if opted Mar 16, 2022
@TwiN TwiN merged commit fdec317 into TwiN:master Mar 16, 2022
TwiN added a commit that referenced this pull request Mar 16, 2022
@TwiN
fix: Display "<redacted>" instead of "host" in errors (#262)
bd4b91b
TwiN added a commit that referenced this pull request Mar 16, 2022
@TwiN
test: Improve coverage for endpoint health evaluation edge cases (#262)
0bf2271
@TwiN
Copy link
Owner

TwiN commented Mar 23, 2022

Released in v3.7.0

@shashank68 shashank68 deleted the hide_host_err branch March 24, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TwiN TwiN TwiN approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: hide-hostname doesn't remove sanitize errors
2 participants
@shashank68 @TwiN