feat(alerting): Persist triggered alerts across application restart #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TwiN
added
feature
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #764 +/- ##
==========================================
+ Coverage 80.56% 80.79% +0.23%
==========================================
Files 64 64
Lines 4249 4368 +119
==========================================
+ Hits 3423 3529 +106
- Misses 627 638 +11
- Partials 199 201 +2 ☔ View full report in Codecov by Sentry. |
|
@TwiN I tried you PR since I was trying to look at this feature myself. When I restart gatus for the second time I re-receive all the OK notification. The KO ones seems fine. Later today I will try to look more in detail your commit to give you some more details. |
|
@LCerebo Much appreciated! Due to the nature of the change, I will probably let it sit in latest for a few weeks in case somebody reports an issue with it. |
github-merge-queue bot
referenced
this pull request
in chezmoi-sh/atlas
May 29, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | OpenSSF | |---|---|---|---| | [TwiN/gatus](https://togithub.com/TwiN/gatus) | minor | `v5.10.0` -> `v5.11.0` | [](https://securityscorecards.dev/viewer/?uri=github.com/TwiN/gatus) | --- ### Release Notes <details> <summary>TwiN/gatus (TwiN/gatus)</summary> ### [`v5.11.0`](https://togithub.com/TwiN/gatus/releases/tag/v5.11.0) [Compare Source](https://togithub.com/TwiN/gatus/compare/v5.10.0...v5.11.0) ##### What's Changed - feat(alerting): Persist triggered alerts across application restart by [@​TwiN](https://togithub.com/TwiN) in [https://github.com/TwiN/gatus/pull/764](https://togithub.com/TwiN/gatus/pull/764) - fix(alerting): Make Microsoft Teams title customizable by [@​rahulchordiya](https://togithub.com/rahulchordiya) in [https://github.com/TwiN/gatus/pull/731](https://togithub.com/TwiN/gatus/pull/731) - refactor: Break core package into multiple packages under config/endpoint by [@​TwiN](https://togithub.com/TwiN) in [https://github.com/TwiN/gatus/pull/759](https://togithub.com/TwiN/gatus/pull/759) - chore(deps): bump github.com/gofiber/fiber/v2 from 2.52.1 to 2.52.4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/TwiN/gatus/pull/739](https://togithub.com/TwiN/gatus/pull/739) - chore(deps): bump codecov/codecov-action from 4.3.0 to 4.4.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/TwiN/gatus/pull/765](https://togithub.com/TwiN/gatus/pull/765) ##### New Contributors - [@​rahulchordiya](https://togithub.com/rahulchordiya) made their first contribution in [https://github.com/TwiN/gatus/pull/731](https://togithub.com/TwiN/gatus/pull/731) **Full Changelog**: TwiN/gatus@v5.10.0...v5.11.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/chezmoi-sh/atlas). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNzcuOCIsInVwZGF0ZWRJblZlciI6IjM3LjM3Ny44IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #679
Checklist
README.md, if applicable.