Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(alerting): Add optional field alerting.mattermost.channel #823

Merged
merged 6 commits into from
Sep 18, 2024

Conversation

ggerrit
Copy link
Contributor

@ggerrit ggerrit commented Jul 15, 2024

For issue #646

Summary

Checklist

  • Tested and/or added tests to validate that the changes work as intended, if applicable.
  • Updated documentation in README.md, if applicable.

alerting/provider/mattermost/mattermost.go Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.96%. Comparing base (f55f39f) to head (263098a).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #823   +/-   ##
=======================================
  Coverage   78.95%   78.96%           
=======================================
  Files          71       71           
  Lines        4767     4768    +1     
=======================================
+ Hits         3764     3765    +1     
  Misses        794      794           
  Partials      209      209           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TwiN TwiN added the area/alerting Related to alerting label Jul 21, 2024
@TwiN TwiN added the feature New feature or request label Sep 18, 2024
@TwiN TwiN changed the title Add optional field alerting.mattermost.channel feat(alerting): Add optional field alerting.mattermost.channel Sep 18, 2024
@TwiN TwiN merged commit b0c2f1e into TwiN:master Sep 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/alerting Related to alerting feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants