Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): Support 30d badges #836

Merged
merged 8 commits into from
Aug 12, 2024
Merged

feat(storage): Support 30d badges #836

merged 8 commits into from
Aug 12, 2024

Conversation

TwiN
Copy link
Owner

@TwiN TwiN commented Aug 9, 2024

Summary

Add support for 30d uptime badges, response time badges and response time chart.

Resolves #128

Checklist

  • Tested and/or added tests to validate that the changes work as intended, if applicable.
  • Updated documentation in README.md, if applicable.

@TwiN TwiN added feature New feature or request area/storage Related to storage area/ui Related to the user interface area/api Related to the REST API labels Aug 9, 2024
Repository owner deleted a comment from codecov-commenter Aug 11, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 78.02198% with 20 lines in your changes missing coverage. Please review.

Project coverage is 78.85%. Comparing base (90ffea9) to head (dcfbe24).
Report is 1 commits behind head on master.

Files Patch % Lines
storage/store/sql/sql.go 86.11% 5 Missing and 5 partials ⚠️
api/badge.go 20.00% 8 Missing ⚠️
storage/store/memory/uptime.go 0.00% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #836      +/-   ##
==========================================
- Coverage   78.97%   78.85%   -0.13%     
==========================================
  Files          69       69              
  Lines        4538     4621      +83     
==========================================
+ Hits         3584     3644      +60     
- Misses        754      771      +17     
- Partials      200      206       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TwiN TwiN changed the title feat(storage): Add support for 30d uptime badge feat(storage): Add support for 30d badges Aug 12, 2024
@TwiN TwiN changed the title feat(storage): Add support for 30d badges feat(storage): Support 30d badges Aug 12, 2024
@TwiN TwiN merged commit dd435a8 into master Aug 12, 2024
1 check passed
@TwiN TwiN deleted the feat/30d-uptime branch August 12, 2024 02:40
@amai2012
Copy link

amai2012 commented Nov 5, 2024

I'm still waiting for the 30 days' badges to appear - and I've deployed >30 days ago.

@TwiN
Copy link
Owner Author

TwiN commented Nov 5, 2024

@amai2012 What image tag are you using? Because it's definitely available:

Uptime: uptime 30d

Response time: response time 30d

By "waiting for the 30d badge to appear", are you referring to the single endpoint view? If so, it doesn't appear there, but you can still use it as a badge.

@amai2012
Copy link

amai2012 commented Nov 8, 2024

@TwiN Ok, my misunderstanding. Indeed I can access the badges, but was missing it in the endpoint view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Related to the REST API area/storage Related to storage area/ui Related to the user interface feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase data retention to 30 days
3 participants