Skip to content

feat: Add nodeSelector, tolerations and affinity to pre-delete-cleanup job template #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2025
Merged

feat: Add nodeSelector, tolerations and affinity to pre-delete-cleanup job template #714

merged 1 commit into from
Jul 7, 2025

Conversation

@clement0010
Copy link
Contributor

@clement0010 clement0010 commented Jul 7, 2025

Changes

  • Update pre-delete-cleanup job template to include nodeSelector, tolerations, and affinity fields.

@clement0010 clement0010 requested a review from Copilot July 7, 2025 13:10
Copilot AI reviewed Jul 7, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR extends the pre-delete-cleanup Kubernetes Job template by adding support for specifying pod scheduling constraints directly via Helm values.

  • Introduces nodeSelector, affinity, and tolerations blocks driven by .Values
  • Preserves existing command and restartPolicy configuration
Comments suppressed due to low confidence (2)

deploy/twingate-operator/templates/pre-delete-cleanup.yaml:27

  • Update the Chart's values.yaml and README to define and document the new nodeSelector, tolerations, and affinity fields with default examples so users know how to configure them.
      {{- with .Values.nodeSelector }}

deploy/twingate-operator/templates/pre-delete-cleanup.yaml:27

  • Add tests (e.g., Helm template unit tests or integration tests) to verify that nodeSelector, affinity, and tolerations blocks are rendered correctly when provided in values.
      {{- with .Values.nodeSelector }}

minhtule
minhtule approved these changes Jul 7, 2025
View reviewed changes
Copy link
Contributor

@minhtule minhtule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@minhtule minhtule merged commit e6ce90b into main Jul 7, 2025
18 checks passed
@minhtule minhtule deleted the feat/support-node-selector-affinity-and-tolerations branch July 7, 2025 15:37
github-actions bot pushed a commit that referenced this pull request Sep 8, 2025
@dependabot
chore: Bump pytest-cov from 6.2.1 to 6.3.0 (#776)
24db1e9 
Bumps [pytest-cov](https://github.com/pytest-dev/pytest-cov) from 6.2.1
to 6.3.0.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/pytest-dev/pytest-cov/blob/master/CHANGELOG.rst">pytest-cov's
changelog</a>.</em></p>
<blockquote>
<h2>6.3.0 (2025-09-06)</h2>
<ul>
<li>Added support for markdown reports.
Contributed by Marcos Boger in
<code>[#712](pytest-dev/pytest-cov#712)
&lt;https://github.com/pytest-dev/pytest-cov/pull/712&gt;</code>_
and <code>[#714](pytest-dev/pytest-cov#714)
&lt;https://github.com/pytest-dev/pytest-cov/pull/714&gt;</code>_.</li>
<li>Fixed some formatting issues in docs.
Anonymous contribution in
<code>[#706](pytest-dev/pytest-cov#706)
&lt;https://github.com/pytest-dev/pytest-cov/pull/706&gt;</code>_.</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/pytest-dev/pytest-cov/commit/a69d1abfea81138099f7da6ad114a2357b994b86"><code>a69d1ab</code></a>
Bump version: 6.2.1 → 6.3.0</li>
<li><a
href="https://github.com/pytest-dev/pytest-cov/commit/475bf32521d4a75646255369b766cfad55bab1fb"><code>475bf32</code></a>
Update changelog.</li>
<li><a
href="https://github.com/pytest-dev/pytest-cov/commit/3834009b902adaad28fed0bd9aba3889b387df4b"><code>3834009</code></a>
Add GitHub Actions example and fix example to not break with default
markdown...</li>
<li><a
href="https://github.com/pytest-dev/pytest-cov/commit/0824728a5ea0b779ab474d754951413995ce48bd"><code>0824728</code></a>
Small phrasing adustments in Markdown docs</li>
<li><a
href="https://github.com/pytest-dev/pytest-cov/commit/474c1f4e38cda390a9abfa3c843a1fc179bfba0e"><code>474c1f4</code></a>
Move markdown dest files check to StoreReport for earlier error and
parser.er...</li>
<li><a
href="https://github.com/pytest-dev/pytest-cov/commit/7b21833031fdbbdc8b383878788addb5dbc148c6"><code>7b21833</code></a>
Default markdown-append to coverage.md and raise warning if both
markdown opt...</li>
<li><a
href="https://github.com/pytest-dev/pytest-cov/commit/3a15312a543c2f3822c244dccc1b2a4896b1578a"><code>3a15312</code></a>
Fix usage of Path.open() to write/append to files</li>
<li><a
href="https://github.com/pytest-dev/pytest-cov/commit/4b79449a98e6aaf4d99b99ca6323f9bc77c6bda6"><code>4b79449</code></a>
Change output file cov-append.md in md-append example</li>
<li><a
href="https://github.com/pytest-dev/pytest-cov/commit/40e9e8e9a93edaa6d9aadbf2efa60d91f97b9dff"><code>40e9e8e</code></a>
Add docs and update AUTHORS.rst</li>
<li><a
href="https://github.com/pytest-dev/pytest-cov/commit/f5ca33aa6f873d03004e9dcc591a90e61f7676ac"><code>f5ca33a</code></a>
Add tests for markdown and markdown-append</li>
<li>Additional commits viewable in <a
href="https://github.com/pytest-dev/pytest-cov/compare/v6.2.1...v6.3.0">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=pytest-cov&package-manager=pip&previous-version=6.2.1&new-version=6.3.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@minhtule minhtule minhtule approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@clement0010 @minhtule