-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixed example parsing for joi version > 14 #52
Conversation
Examples are now objects, as per relase 14.0.0. References: - hapijs/joi#1615 - hapi-swagger/hapi-swagger#540 - hapi-swagger/hapi-swagger#546
0c864a1
to
ea8c729
Compare
👍 |
Hello everybody :), The bug affect our project also. It's possible to merge this PR, pleassseeeee :D ? Thanks guys for your job ;) |
Hey guys, any ETA on this merge? PR is already several months old! Would be very helpful! |
Well because it seemed that it could take some while, I created a fork where this and other PRs are merged. https://github.com/Mairu/joi-to-swagger / https://www.npmjs.com/package/@mairu/joi-to-swagger |
@Twipped have you abandoned this project. It still seems to get a lot of traffic on mom and could use some enhancements. Can you please review this PR? |
Not abandoned, just don't have time to work on it. I originally wrote it for an api service we had at work, but we've now replaced that project with a graphql server. If somebody wants to come on as collab I'd be willing to add them to the repo and npm package. |
Well if wanted, I could do that @Twipped |
@Mairu Done, you're added as a collaborator. Is Mairu your npm username as well? |
Thanks. It is https://www.npmjs.com/~mairu-master. And for all that are waiting, I have vacation from tomorrow on. So it could take one more week until I have time to do some stuff. |
@Mairu you now have publish rights. |
Examples are now objects, as per relase 14.0.0. References: