Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aligned Auth Scopes with Twitch docs #365

Merged
merged 2 commits into from
Jul 19, 2023

Conversation

Bukk94
Copy link

@Bukk94 Bukk94 commented Jul 6, 2023

Auth Scopes fixes

  • Added documentation to Auth Scopes
  • Moved ScopeToString method from PingResponse to Helpers so it's together with other parsing method
  • Corrected old chat:moderate to channel:moderate in ScopeToString (this was forgotten in the previous PR)
  • Removed scope user:edit:broadcast which is no longer valid
  • Removed all old v5 scopes (like openid, channel_read, or channel_editor)
  • Added new Auth scopes:
    • Channel_Read_Guest_Star - channel:read:guest_star
    • Channel_Manage_Guest_Star - channel:manage:guest_star
    • Channel_Manage_Raids - channel:manage:raids
    • Moderator_Read_Guest_Star - moderator:read:guest_star
    • Moderator_Read_Shield_Mode - moderator:read:shield_mode
    • Moderator_Read_Shoutouts - moderator:read:shoutouts
    • Moderator_Manage_Guest_Star - moderator:manage:shield_mode
    • Moderator_Manage_Shield_Mode - moderator:manage:guest_star
    • Moderator_Manage_Shoutouts - moderator:manage:shoutouts
    • Whisper_Read - whispers:read
    • Whisper_Edit - whispers:edit

Minor improvements

  • Updated TwitchPatchAsync in ApiBase to return KeyValuePair
  • Updated ModifyChannelInformationAsync in Channel to return bool if the modification was successful.
  • Extended .gitignore to ignore JetBrain's Rider files
  • Updated C# language from 7.3 to latest

TwitchLib.Api.Core/Common/Helpers.cs Outdated Show resolved Hide resolved
TwitchLib.Api.Core/Common/Helpers.cs Show resolved Hide resolved
@neon-sunset
Copy link

Thank you!

Copy link
Member

@swiftyspiffy swiftyspiffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Syzuna Syzuna merged commit 5b1f933 into TwitchLib:dev Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants