Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Summaries to API Models & Added ContentClassificiationLabel API Endpoint #366

Merged
merged 21 commits into from
Jul 25, 2023
Merged

Added Summaries to API Models & Added ContentClassificiationLabel API Endpoint #366

merged 21 commits into from
Jul 25, 2023

Conversation

koishibuh
Copy link

Added summaries to the following API models: Ads, GetCheermotes, CreateClips, & GetClips

@koishibuh koishibuh changed the base branch from master to dev July 19, 2023 15:44
@koishibuh
Copy link
Author

  • Updated several models to have summaries

  • With Twitch releasing the new Content Classification Labels, several models needed to be updated: GetChannelInformation (TwitchDocs) & ModifyChannelInformation (TwitchDocs) to include the new properties.

  • Created a ContentClassificationLabel Enum with the values that Twitch expects for the Content Classification Labels.

  • TODO: Sorry, should have double checked this, but there is also a new end point called GetContentClassificationLabels (TwitchDocs) that will need to be added. I will attempt to add this tomorrow and try not to break anything. (This should have also been a separate PR my bad)

- Added ContentClassificationLabels class with GetContentClassificationAsync method
- Added GetContentClassificationLabelsResponse with model
@koishibuh
Copy link
Author

Twitch released a new endpoint GetContentClassificationLabels (TwitchDocs) that returns the list of Content Classification Labels so I:

  • Added ContentClassificationLabel to the Api.Helix.Helix class
  • Added ContentClassificationLabels class to Api.Helix with GetContentClassificationAsync method
  • Added GetContentClassificationLabelsResponse with model to Api.Helix.Models.ContentClassificationLabels

Not sure if there is anything other place I was supposed to add things to as I just followed the other classes as an example. I also haven't tested this to make sure it actually works since I don't know how to do that properly.

@koishibuh koishibuh changed the title Added Summaries to API Models Added Summaries to API Models & Added ContentClassificiationLabel API Endpoint Jul 21, 2023
- Fixed summary bug in Anayltics.GetExtensionAnalyticsAsync() that copied the incorrect startedAt & endedAt information
- Added summary for ExtensionAnalytics
- Added summary for GetExtensionResponse
- Added summary for GameAnalytics
- Added summary for GetGameAnalyticsResponse
- Added summary for DateRange
@koishibuh
Copy link
Author

  • Updated summaries for Ad & Analytics in Api.Helix to include links to Twitch API Documents
  • Found a bug in the summary for Analytics.GetExtensionAnalyticsAsync() that looks like was a copy-paste error from GetGameAnalytics which had different Started_At & Ended_at information. Updated to correct information.
  • Added missing Pagination property in GetExtensionAnalyticsResponse

@Mahsaap Mahsaap merged commit 849a297 into TwitchLib:dev Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants