Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nullable annotation and extraction of RaisesAsync from modified Assert class to new MyAssert class. #249

Merged
merged 1 commit into from
Oct 4, 2023
Merged

nullable annotation and extraction of RaisesAsync from modified Assert class to new MyAssert class. #249

merged 1 commit into from
Oct 4, 2023

Conversation

AoshiW
Copy link

@AoshiW AoshiW commented Sep 21, 2023

  • Removed the modified class Assert because it makes no sense to copy the whole implementation when we are interested in only 1 function (RaisesAsync) and moved that function to a new class (MyAssert).
  • enabled nullable annotation for TwitchLib.Client.Test

swiftyspiffy
swiftyspiffy approved these changes Sep 24, 2023
View reviewed changes
Copy link
Member

@swiftyspiffy swiftyspiffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@swiftyspiffy swiftyspiffy merged commit 0c05d2e into TwitchLib:dev Oct 4, 2023
@AoshiW AoshiW deleted the test-nullable branch October 4, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swiftyspiffy swiftyspiffy swiftyspiffy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AoshiW @swiftyspiffy