Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recreate Client if Disposed #31

Closed
wants to merge 1 commit into from
Closed

Recreate Client if Disposed #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/TwitchLib.Communication/Clients/ClientBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,8 +252,17 @@ private async Task<bool> OpenPrivateAsync(bool isReconnect)
await Task.Delay(Options.ReconnectionPolicy.GetReconnectInterval(), CancellationToken.None);
}

await ConnectClientAsync();
Options.ReconnectionPolicy.ProcessValues();
try
{
await ConnectClientAsync();
Options.ReconnectionPolicy.ProcessValues();
}
catch (ObjectDisposedException)
{
Logger?.TraceAction(GetType(), "object disposed. Recreating.");
Client = CreateClient();
}

first = false;
}

Expand Down
4 changes: 4 additions & 0 deletions src/TwitchLib.Communication/Clients/WebsocketClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,10 @@ protected override async Task ConnectClientAsync()
// occurs if the Tasks are canceled by the CancellationTokenSource.Token
Logger?.LogExceptionAsInformation(GetType(), ex);
}
catch (ObjectDisposedException)
{
throw;
}
catch (Exception ex)
{
Logger?.LogExceptionAsError(GetType(), ex);
Expand Down