-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor chat connections and allow dynamically joining chats #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Felk
changed the title
Draft: refactor chat connections and allow dynamically joining chats
refactor chat connections and allow dynamically joining chats
Feb 6, 2024
Felk
commented
Feb 6, 2024
Comment on lines
+102
to
+104
// TODO https://github.com/TwitchLib/TwitchLib.Api/pull/386 | ||
await twitchApi.Helix.Chat.SendChatMessage(reply.ChannelId, _senderUserId, reply.Message /*, replyParentMessageId: reply.ReplyToId*/); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to fix this bit if/when TwitchLib/TwitchLib.Api#386 is merged and available on nuget via a prerelease
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…ubscription monitoring optional
Felk
force-pushed
the
chat_connection_updates
branch
from
February 12, 2024 16:14
f288002
to
afa5556
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CoStreamInputsEnabled
(inside twitch connection config) (default false)CoStreamInputsOnlyLive
, default true)CoStreamInputsOnlyLive
is set to true, automatically leaves channgels that are no longer liveCoStreamInputsEnabled
to false after the event and it stops joining other channels