fix(wallet): limit WalletConnect backup to Defly and Pera #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update `setActive` method in `DeflyWallet` to only backup Pera - Update `setActive` method in `PeraWallet` to only backup Defly - Ensure WalletConnect sessions are only backed up for relevant wallets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refines the WalletConnect session management fix implemented in PR #275. It addresses an oversight where backups were being created for all wallet types, not just Defly and Pera which use WalletConnect v1.
Details
setActivemethod inDeflyWalletto only backup Pera wallet sessionssetActivemethod inPeraWalletto only backup Defly wallet sessionsThese changes further improve the reliability of wallet switching, ensuring that WalletConnect sessions are managed correctly only for the wallets that require it.
Related Issues
This PR is part of the ongoing fix for issue #274, further refining the solution to the WalletConnect session management problems.