test(react): fix React testing warnings with proper act() usage #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix React testing warnings by properly wrapping state updates and effects
in `act()` with `async`/`await`. This ensures all state updates and side
effects complete before making assertions.
- Make test functions async where needed
- Wrap renders and state updates in `act(async () => {...})`
- Add small delays where needed for effects to complete
- Fix `setActive` and `setActiveAccount` test implementation
- Simplify store state change test assertions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes React testing warnings by properly handling state updates and effects in the test suite. These warnings occurred because some state updates were happening outside of
act()wrappers, which React uses to ensure tests run in a way that matches real rendering.Details
act(async () => {...})act(async () => {...})setActiveandsetActiveAccounttest implementation