Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate top down #155

Open
wants to merge 37 commits into
base: new_webapp
Choose a base branch
from

Conversation

darya-ver
Copy link
Collaborator

We have implemented a TopDown search for Hoogle+.

Here are our results - you can request access to view them if you don't already have access (https://docs.google.com/spreadsheets/d/1wfBqsi45Od8He0we6RuQls4g0LEElOYN9MBXhKpWBxs/edit#gid=1925983337&fvid=861486555)

EpicOrange added 30 commits July 1, 2020 21:44
…k/suites/working.yml src/TopDown/Synthesize.hs !
@darya-ver darya-ver requested a review from aaronguo1996 July 20, 2020 22:36
@@ -0,0 +1,234 @@
{-# LANGUAGE TypeSynonymInstances #-}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please restructure this file to reuse the existing code. You may add a flag in app/HooglePlus.hs to indicate whether to run top-down or tygar.

# if __name__ == '__main__':
# init()

# cl_opts = cmdline()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete these commented code

both (a -> b) -> (a, a) -> (b, b) 599.52 -
firstJust a -> [Maybe a] -> a 599.44 -
mapEither (a -> Either b c) -> [a] -> ([b], [c]) 599.45 -
mapMaybes (a -> Maybe b) -> [a] -> Maybe b 599.48 -
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not commit the experiment results, you may keep them in the shared google driver

@@ -138,7 +140,8 @@ checkExampleOutput mdls env typ prog exs = do
| otherwise = case currOutput of
Left e -> return Nothing
Right o -> do
expectedOutput <- runStmt mdls (printf "Test.ChasingBottoms.approxShow 100 (%s)" $ output ex)
expectedOutput <- runStmt mdls (printf "(%s)" $ output ex)
-- expectedOutput <- runStmt mdls (printf "Test.ChasingBottoms.approxShow 100 (%s)" $ output ex)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete code that is commented out

@@ -0,0 +1,126 @@
module HooglePlus.SynthesizeTheirs(synthesize, envToGoal) where

import Database.Environment
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this file renaming

@@ -22,7 +22,8 @@ import Database.Generate
import Database.Download
import Database.Util
import Synquid.Util (showme)
import HooglePlus.Synthesize
import TopDown.Synthesize
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See TopDown/Synthesize about how to change this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants